Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump :gun to 2.0.0-rc.1. #240

Merged
merged 1 commit into from
May 18, 2021
Merged

Bump :gun to 2.0.0-rc.1. #240

merged 1 commit into from
May 18, 2021

Conversation

jchristgit
Copy link
Collaborator

This prevents dependency problems when trying to use nostrum with e.g. Phoenix,
as outlined in #236. It also sets the foundation for using :gun as our one
and only HTTP client, instead of relying on an extra library here.

Fixes #236.

@jchristgit jchristgit requested a review from Kraigie May 18, 2021 18:16
Copy link
Owner

@Kraigie Kraigie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment we should probably look into, LGTM otherwise!

mix.exs Outdated Show resolved Hide resolved
This prevents dependency problems when trying to use nostrum with e.g. Phoenix,
as outlined in #236. It also sets the foundation for using `:gun` as our one
and only HTTP client, instead of relying on an extra library here.

Fixes #236.
@jchristgit
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update (or relax) dependencies
2 participants