Add get_guild_ban and fix typo. #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchristgit
requested changes
Dec 28, 2020
There was a problem hiding this comment.
Hi @Xh4H, sorry for the late review. I think we need to adjust the return type, as the get guild ban route returns a special object, or am I misinterpreting the docs?
https://discord.com/developers/docs/resources/guild#ban-object
I understand if you don't want to work on this anymore, just drop a short note and we'll take up on it.
|
Hi @Xh4H, did you find some time to look into this? Otherwise I'd push changes for my comment and merge 😁 |
|
I've cherry-picked and added the struct changes in #224, closing here |
jchristgit
added a commit
that referenced
this pull request
May 14, 2021
…uct. (#224) * Add get_guild_ban and fix typo. * Decode into `Guild.Ban` struct. Co-authored-by: Juan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing API route.