fix: improve avro library detection #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 5, 2024 11:31
So far we checked for the presence of the library in the target schema class file but this library could be loaded indirectly and not explicitely listed. As a fallback, we now: - look for the library string without the import keyword, to allow to specify it using the schemas static annotation if needed (for instance '@Schema(library="com.sksamuel.avro4s")') - search for the library in the build.sbt as well.
Instead of requiring the project to load the com.lihaoyi.upickle and com.lihaoyi.os-lib libraries in the project, we now dynamically add them to the dependencies when running the schema generation command. It still not bulletproof as it could lead to version conflict with existing libraries but it will good enough for now :-)
aftouh
approved these changes
Feb 5, 2024
yannrouillard
deleted the
fix/PTFM-9207/fix-some-issues-in-kafka-schema-generation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we checked for the presence of the library in the target schema
class file but this library could be loaded indirectly and not
explicitely listed.
As a fallback, we now:
look for the library string without the import keyword, to allow
to specify it using the schemas static annotation if needed
(for instance 'Schema(library="com.sksamuel.avro4s")')
search for the library in the build.sbt as well.