Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new check for topic name compliance in gitops validation #30

Merged

Conversation

yannrouillard
Copy link
Contributor

No description provided.

@yannrouillard yannrouillard requested a review from aftouh February 5, 2024 09:19
@yannrouillard yannrouillard self-assigned this Feb 5, 2024
@yannrouillard yannrouillard force-pushed the feat/PTFM-9207/implement-additional-checks-for-topic-name branch 2 times, most recently from 70b9c6a to a40e2f5 Compare February 5, 2024 09:37
Yann Rouillard added 3 commits February 5, 2024 10:38
In order to prepare to update it to allow for easy extension with
additional checks.

On the way, we also enable some caching to speed up the gitops
validation when the same chart version is used across several services.
@yannrouillard yannrouillard force-pushed the feat/PTFM-9207/implement-additional-checks-for-topic-name branch from a40e2f5 to 5de7ad9 Compare February 5, 2024 09:38
Copy link

@aftouh aftouh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@yannrouillard yannrouillard merged commit 5bdeea0 into main Feb 5, 2024
@yannrouillard yannrouillard deleted the feat/PTFM-9207/implement-additional-checks-for-topic-name branch February 5, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants