Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Windows Wheels #164

Closed
wants to merge 8 commits into from
Closed

Conversation

naveen521kk
Copy link
Contributor

@naveen521kk naveen521kk commented Oct 13, 2020

Fixes #141
Builds a wheel installable all over python3 and not specific to python version but specific to platform version. The wheel generated by Github Actions can be installed in any python version(v3) but specific to whether it is x86 or x64.

Thanks to https://github.com/preshing/cairo-windows for created compiled cairo dlls.
Also, inspiration taken from

It works on my PC.(Windows 10 x64)

@naveen521kk
Copy link
Contributor Author

naveen521kk commented Oct 13, 2020

Also, fixes Kozea/CairoSVG#279
I suggest the same thing can be done on weasyprint to make it self contained. Also, after a new release of Cairo (It will contain meson build system), the same thing can be done other platforms like Linux and Mac.

@naveen521kk
Copy link
Contributor Author

Any idea's will this be merged?

@naveen521kk naveen521kk deleted the wheel-windows branch October 17, 2020 19:15
@liZe
Copy link
Member

liZe commented Oct 17, 2020

Any idea's will this be merged?

It could be. Why did you close the PR?

@naveen521kk naveen521kk restored the wheel-windows branch October 18, 2020 03:27
@naveen521kk
Copy link
Contributor Author

naveen521kk commented Oct 18, 2020

I had to close this because I really had to go(will not be available till next year) and if any changes requested I wouldn't be able to do it.
I am reopening it. Anyhow, I wouldn't be able to come around here though.

@naveen521kk
Copy link
Contributor Author

Can this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create wheels
2 participants