fix: calculate ex ratio correctly #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had lost a negative sign accidentally in 4833bf6.
|
Thank you.
Yes, that’s a problem with no perfect solution right now. We could at least test that the ex and ch units give "suitable" values to avoid obvious problems like this one. I’ll add these tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had lost a negative sign accidentally in 4833bf6. Sorry about that!
I couldn't come up with a good way to test this off the top of my head especially given that it seems we can't necessarily rely on the testing font being available for use since we don't yet support
@font-facein these computed values.