fix: more robustly handle unlayout'ing a footnote #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug accidentally introduced in Kozea#1566, where we would try to unlayout a footnote that had not yet been laid out, if the algorithm decided that there would be insufficient space on a page before laying out a further footnote.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug accidentally introduced in #1566, where we would try to unlayout a footnote that had not yet been laid out, if the algorithm decided that there would be insufficient space on a page before laying out a further footnote.
(The fix is to check to see whether we've actually laid it out yet - or, equivalently, put things back as if we haven't. Otherwise we get a ValueError from trying to remove from
self.reported_footnotesand a duplicated entry inself.footnotes.)