Handle 'inherit' value for shorthand properties #1524
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1007.
The first commit b18b67a fixes
inherit
fortext-decoration
.Using
@generic_expander
is a good idea, because it handles a lot of things, includinginherit
andinitial
automatically, and could handle other values likeunset
andrevert
. Using@generic_expander
requires to yield tokens, not computed values, but that’s a fair trade-off and we should use it everywhere it’s possible.We can then test the
inherit
value for all the expanders, as it’s now done fortext-decoration
.If anyone (@ckepper?) is interested in updating this PR to handle other expanders, don’t hesitate to add a comment!
Here are the properties that aren’t / weren’t supported:
text-decoration
(b18b67a)word-wrap
(#1007 Make 'inherit' value work correctly forword-wrap
#1525)page-break-after/before
border-radius
page-break-inside
line-clamp
flex-flow
flex
text-align