Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 'inherit' value for shorthand properties #1524

Merged
merged 11 commits into from
Jan 8, 2022
Merged

Handle 'inherit' value for shorthand properties #1524

merged 11 commits into from
Jan 8, 2022

Conversation

liZe
Copy link
Member

@liZe liZe commented Dec 14, 2021

Fix #1007.

The first commit b18b67a fixes inherit for text-decoration.

Using @generic_expander is a good idea, because it handles a lot of things, including inherit and initial automatically, and could handle other values like unset and revert. Using @generic_expander requires to yield tokens, not computed values, but that’s a fair trade-off and we should use it everywhere it’s possible.

We can then test the inherit value for all the expanders, as it’s now done for text-decoration.

If anyone (@ckepper?) is interested in updating this PR to handle other expanders, don’t hesitate to add a comment!

Here are the properties that aren’t / weren’t supported:

@liZe liZe added the feature New feature that should be supported label Dec 14, 2021
@liZe liZe added this to the 55.0 milestone Dec 14, 2021
@liZe liZe marked this pull request as ready for review December 28, 2021 17:19
@liZe
Copy link
Member Author

liZe commented Jan 3, 2022

@ckepper Thanks for your contribution, it will be merged soon 💚.

If you’re interested in these features, don’t hesitate to review this PR and give some feedback! If there’s anything you don’t understand, just ask, I’ll be happy to help.

@liZe liZe merged commit b224460 into master Jan 8, 2022
@liZe liZe deleted the inherit branch January 8, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature that should be supported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make 'inherit' value work correctly for shorthand properties
2 participants