Handle box-decoration-break #771

stolzweb · 2019-01-18T19:58:22Z

i know there is the closed issue #139. But i think i really don't have a chance to solve my problem without this css "box-decoration-break". In the attached Screen you can see the splitted grey box. On the second page the text starts at the top of the grey box, but i need there a padding between box and text. The grey box has a padding-top, but that does not help. Is there a possibility to solve this problem? I also would pay for the implementation :)

liZe · 2019-01-21T22:13:08Z

i know there is the closed issue #139.

That was 5 years ago. It's time to think of this now 😄.

Is there a possibility to solve this problem?

Yes, you're right, box-decoration-break is what you need.

I also would pay for the implementation :)

Thank you! If you're interested, you can contribute to our Patreon campaign. Some tiers give you the possibility to select an issue we'll work on. It's monthly donation but you can stop when you want.

liZe · 2019-02-27T09:32:05Z

We should be able to fix #115 too.

liZe · 2019-02-28T14:56:34Z

I'm currently working on it on the box-decoration-break branch. It's far from being perfect for now, but it should fix your use case already. Feel free to test and tell me if it works!

liZe · 2019-03-15T14:16:02Z

What's left to do:

Related to #771. Fixes http://test.weasyprint.org/suite-css21/chapter13/section2/test7/

Related to #771.

And add related tests of course! Related to #771.

liZe · 2019-03-18T17:17:08Z

@stolzweb I'll add tests and merge the branch into master if everything goes well. I won't implement the background part of the spec if you're not interested in it. Feel free to test and tell me if everything's OK for you!

stolzweb · 2019-03-19T19:29:30Z

Sorry i was verry busy the last view months with other projects. Thanks a lot for doing this great job! I just tested it in my project. There are some tiny issues which eventually could be fixed.

my grey box has a padding of 4mm and a margin-bottom of 4mm, inside this grey box is sometimes a table, while cutting the table, For my it looks like the padding bottom is not added after cutting the table.

liZe · 2019-03-20T09:45:48Z

Sorry i was verry busy the last view months with other projects.

No problem!

my grey box has a padding of 4mm and a margin-bottom of 4mm, inside this grey box is sometimes a table, while cutting the table, For my it looks like the padding bottom is not added after cutting the table.

Small sample showing the problem:

<style>
  @page { size: 80px; margin: 0 }
  body { margin: 0 }
  table { border: 0; border-collapse: collapse }
  td { background: red; border: none; height: 20px; padding: 0 }
  section { padding: 10px; background: yellow; margin: 5px; box-decoration-break: clone }
</style>
<section>
  <table>
    <tr>
      <td>a</td>
    </tr>
    <tr>
      <td>b</td>
    </tr>
    <tr>
      <td>c</td>
    </tr>
    <tr>
      <td>d</td>
    </tr>
  </table>
</section>

Related to #771.

liZe · 2019-03-20T12:40:49Z

my grey box has a padding of 4mm and a margin-bottom of 4mm, inside this grey box is sometimes a table, while cutting the table, For my it looks like the padding bottom is not added after cutting the table.

This problem has been fixed when using box-decoration-break: clone.

What's sad is that with slice (the default value, the default case before box-decoration-break was supported) the box may go further than the bottom of the page if the bottom padding or border is too wide. The bug is in WeasyPrint since the beginning and is not easy to fix, but it shouldn't bother you.

I've added a passing test for your clone case and a failing test for the slice case.

If everything's OK for you, I'll release the current master branch as version 46.

stolzweb · 2019-03-20T14:00:49Z

Hi Guilllaume Thanks a lot. It is perfect! Looking forward to the version 46 br manuel Herzliche Grüsse Manuel Stolz

…

_______________________ Stolz WEB GmbH Davidstrasse 40 9000 St. Gallen T: +41 (0)71 511 38 20 F: +41 (0)71 511 38 29 Skype: stolzweb www.stolzweb.ch

------ Originalnachricht ------ Von: "Guillaume Ayoub" <[email protected]> An: "Kozea/WeasyPrint" <[email protected]> Cc: "stolzweb" <[email protected]>; "Mention" <[email protected]> Gesendet: 20.03.2019 13:40:52 Betreff: Re: [Kozea/WeasyPrint] Handle box-decoration-break (#771)

>my grey box has a padding of 4mm and a margin-bottom of 4mm, inside >this grey box is sometimes a table, while cutting the table, For my it >looks like the padding bottom is not added after cutting the table. > This problem has been fixed when using box-decoration-break: clone. What's sad is that with slice (the default value, the default case before box-decoration-break was supported) the box may go further than the bottom of the page if the bottom padding or border is too wide. The bug is in WeasyPrint since the beginning and is not easy to fix, but it shouldn't bother you. I've added a passing test for your clone case and a failing test for the slice case. If everything's OK for you, I'll release the current master branch as version 46. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#771 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ai6Z3kbHB_70pORNB7VozV9_F_iPKfG7ks5vYixUgaJpZM4aIjBu>.

liZe · 2019-03-20T16:43:07Z

Version 46 has been released!

stolzweb · 2019-03-20T19:40:07Z

thanks a lot Herzliche Grüsse Manuel Stolz

…

_______________________ Stolz WEB GmbH Davidstrasse 40 9000 St. Gallen T: +41 (0)71 511 38 20 F: +41 (0)71 511 38 29 Skype: stolzweb www.stolzweb.ch

------ Originalnachricht ------ Von: "Guillaume Ayoub" <[email protected]> An: "Kozea/WeasyPrint" <[email protected]> Cc: "stolzweb" <[email protected]>; "Mention" <[email protected]> Gesendet: 20.03.2019 17:43:10 Betreff: Re: [Kozea/WeasyPrint] Handle box-decoration-break (#771)

Version 46 has been released! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#771 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ai6Z3i2je6JevzehdiOm9wLZnP3ybxChks5vYmUegaJpZM4aIjBu>.

stolzweb · 2019-05-31T15:41:36Z

Hi What do i have to do to force the "text-overflow: ellipsis" issue? :) br manuel

…

_______________________ Stolz WEB GmbH Davidstrasse 40 9000 St. Gallen T: +41 (0)71 511 38 20 F: +41 (0)71 511 38 29 Skype: stolzweb www.stolzweb.ch

------ Originalnachricht ------ Von: "Guillaume Ayoub" <[email protected]> An: "Kozea/WeasyPrint" <[email protected]> Cc: "stolzweb" <[email protected]>; "Mention" <[email protected]> Gesendet: 20.03.2019 17:43:10 Betreff: Re: [Kozea/WeasyPrint] Handle box-decoration-break (#771)

Version 46 has been released! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#771 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ai6Z3i2je6JevzehdiOm9wLZnP3ybxChks5vYmUegaJpZM4aIjBu>.

This TODO has been fixed with #771.

Version 50 ---------- Released on 2019-09-19. New features: * `#209 <https://github.com/Kozea/WeasyPrint/issues/209>`_: Make ``break-*`` properties work inside tables * `#661 <https://github.com/Kozea/WeasyPrint/issues/661>`_: Make blocks with ``overflow: auto`` grow to include floating children Bug fixes: * `#945 <https://github.com/Kozea/WeasyPrint/issues/945>`_: Don't break pages between a list item and its marker * `#727 <https://github.com/Kozea/WeasyPrint/issues/727>`_: Avoid tables lost between pages * `#831 <https://github.com/Kozea/WeasyPrint/issues/831>`_: Ignore auto margins on flex containers * `#923 <https://github.com/Kozea/WeasyPrint/issues/923>`_: Fix a couple of crashes when splitting a line twice * `#896 <https://github.com/Kozea/WeasyPrint/issues/896>`_: Fix skip stack order when using a reverse flex direction Contributors: - grewn0uille - Guillaume Ayoub Version 49 ---------- Released on 2019-09-11. Performance: * Speed and memory use have been largely improved. New features: * `#700 <https://github.com/Kozea/WeasyPrint/issues/700>`_: Handle ``::marker`` pseudo-selector * `135dc06c <https://github.com/Kozea/WeasyPrint/commit/135dc06c>`_: Handle ``recto`` and ``verso`` parameters for page breaks * `#907 <https://github.com/Kozea/WeasyPrint/pull/907>`_: Provide a clean way to build layout contexts Bug fixes: * `#937 <https://github.com/Kozea/WeasyPrint/issues/937>`_: Fix rendering of tables with empty lines and rowspans * `#897 <https://github.com/Kozea/WeasyPrint/issues/897>`_: Don't crash when small columns are wrapped in absolute blocks * `#913 <https://github.com/Kozea/WeasyPrint/issues/913>`_: Fix a test about gradient colors * `#924 <https://github.com/Kozea/WeasyPrint/pull/924>`_: Fix title for document with attachments * `#917 <https://github.com/Kozea/WeasyPrint/issues/917>`_: Fix tests with Pango 1.44 * `#919 <https://github.com/Kozea/WeasyPrint/issues/919>`_: Fix padding and margin management for column flex boxes * `#901 <https://github.com/Kozea/WeasyPrint/issues/901>`_: Fix width of replaced boxes with no intrinsic width * `#906 <https://github.com/Kozea/WeasyPrint/issues/906>`_: Don't respect table cell width when content doesn't fit * `#927 <https://github.com/Kozea/WeasyPrint/pull/927>`_: Don't use deprecated ``logger.warn`` anymore * `a8662794 <https://github.com/Kozea/WeasyPrint/commit/a8662794>`_: Fix margin collapsing between caption and table wrapper * `87d9e84f <https://github.com/Kozea/WeasyPrint/commit/87d9e84f>`_: Avoid infinite loops when rendering columns * `789b80e6 <https://github.com/Kozea/WeasyPrint/commit/789b80e6>`_: Only use in flow children to set columns height * `615e298a <https://github.com/Kozea/WeasyPrint/commit/615e298a>`_: Don't include floating elements each time we try to render a column * `48d8632e <https://github.com/Kozea/WeasyPrint/commit/48d8632e>`_: Avoid not in flow children to compute column height * `e7c452ce <https://github.com/Kozea/WeasyPrint/commit/e7c452ce>`_: Fix collapsing margins for columns * `fb0887cf <https://github.com/Kozea/WeasyPrint/commit/fb0887cf>`_: Fix crash when using currentColor in gradients * `f66df067 <https://github.com/Kozea/WeasyPrint/commit/f66df067>`_: Don't crash when using ex units in word-spacing in letter-spacing * `c790ff20 <https://github.com/Kozea/WeasyPrint/commit/c790ff20>`_: Don't crash when properties needing base URL use var functions * `d63eac31 <https://github.com/Kozea/WeasyPrint/commit/d63eac31>`_: Don't crash with object-fit: non images with no intrinsic size Documentation: * `#900 <https://github.com/Kozea/WeasyPrint/issues/900>`_: Add documentation about semantic versioning * `#692 <https://github.com/Kozea/WeasyPrint/issues/692>`_: Add a snippet about PDF magnification * `#899 <https://github.com/Kozea/WeasyPrint/pull/899>`_: Add .NET wrapper link * `#893 <https://github.com/Kozea/WeasyPrint/pull/893>`_: Fixed wrong nested list comprehension example * `#902 <https://github.com/Kozea/WeasyPrint/pull/902>`_: Add ``state`` to the ``make_bookmark_tree`` documentation * `#921 <https://github.com/Kozea/WeasyPrint/pull/921>`_: Fix typos in the documentation * `#328 <https://github.com/Kozea/WeasyPrint/issues/328>`_: Add CSS sample for forms Contributors: - grewn0uille - Guillaume Ayoub - Raphael Gaschignard - Stani - Szmen - Thomas Dexter - Tontyna Version 48 ---------- Released on 2019-07-08. Dependencies: * CairoSVG 2.4.0+ is now needed New features: * `#891 <https://github.com/Kozea/WeasyPrint/pull/891>`_: Handle ``text-overflow`` * `#878 <https://github.com/Kozea/WeasyPrint/pull/878>`_: Handle ``column-span`` * `#855 <https://github.com/Kozea/WeasyPrint/pull/855>`_: Handle all the ``text-decoration`` features * `#238 <https://github.com/Kozea/WeasyPrint/issues/238>`_: Don't repeat background images when it's not needed * `#875 <https://github.com/Kozea/WeasyPrint/issues/875>`_: Handle ``object-fit`` and ``object-position`` * `#870 <https://github.com/Kozea/WeasyPrint/issues/870>`_: Handle ``bookmark-state`` Bug fixes: * `#686 <https://github.com/Kozea/WeasyPrint/issues/686>`_: Fix column balance when children are not inline * `#885 <https://github.com/Kozea/WeasyPrint/issues/885>`_: Actually use the content box to resolve flex items percentages * `#867 <https://github.com/Kozea/WeasyPrint/issues/867>`_: Fix rendering of KaTeX output, including (1) set row baseline of tables when no cells are baseline-aligned, (2) set baseline for inline tables, (3) don't align lines larger than their parents, (4) force CairoSVG to respect image size defined by CSS. * `#873 <https://github.com/Kozea/WeasyPrint/issues/873>`_: Set a minimum height for empty list elements with outside marker * `#811 <https://github.com/Kozea/WeasyPrint/issues/811>`_: Don't use translations to align flex items * `#851 <https://github.com/Kozea/WeasyPrint/issues/851>`_, `#860 <https://github.com/Kozea/WeasyPrint/issues/860>`_: Don't cut pages when content overflows a very little bit * `#862 <https://github.com/Kozea/WeasyPrint/issues/862>`_: Don't crash when using UTC dates in metadata Documentation: * `#854 <https://github.com/Kozea/WeasyPrint/issues/854>`_: Add a "Tips & Tricks" section Contributors: - Gabriel Corona - Guillaume Ayoub - Manuel Barkhau - Nathan de Maestri - grewn0uille - theopeek Version 47 ---------- Released on 2019-04-12. New features: * `#843 <https://github.com/Kozea/WeasyPrint/pull/843>`_: Handle CSS variables * `#846 <https://github.com/Kozea/WeasyPrint/pull/846>`_: Handle ``:nth()`` page selector * `#847 <https://github.com/Kozea/WeasyPrint/pull/847>`_: Allow users to use a custom SSL context for HTTP requests Bug fixes: * `#797 <https://github.com/Kozea/WeasyPrint/issues/797>`_: Fix underlined justified text * `#836 <https://github.com/Kozea/WeasyPrint/issues/836>`_: Fix crash when flex items are replaced boxes * `#835 <https://github.com/Kozea/WeasyPrint/issues/835>`_: Fix ``margin-break: auto`` Version 46 ---------- Released on 2019-03-20. New features: * `#771 <https://github.com/Kozea/WeasyPrint/issues/771>`_: Handle ``box-decoration-break`` * `#115 <https://github.com/Kozea/WeasyPrint/issues/115>`_: Handle ``margin-break`` * `#821 <https://github.com/Kozea/WeasyPrint/issues/821>`_: Continuous integration includes tests on Windows Bug fixes: * `#765 <https://github.com/Kozea/WeasyPrint/issues/765>`_, `#754 <https://github.com/Kozea/WeasyPrint/issues/754>`_, `#800 <https://github.com/Kozea/WeasyPrint/issues/800>`_: Fix many crashes related to the flex layout * `#783 <https://github.com/Kozea/WeasyPrint/issues/783>`_: Fix a couple of crashes with strange texts * `#827 <https://github.com/Kozea/WeasyPrint/pull/827>`_: Named strings and counters are case-sensitive * `#823 <https://github.com/Kozea/WeasyPrint/pull/823>`_: Shrink min/max-height/width according to box-sizing * `#728 <https://github.com/Kozea/WeasyPrint/issues/728>`_, `#171 <https://github.com/Kozea/WeasyPrint/issues/171>`_: Don't crash when fixed boxes are nested * `#610 <https://github.com/Kozea/WeasyPrint/issues/610>`_, `#828 <https://github.com/Kozea/WeasyPrint/issues/828>`_: Don't crash when preformatted text lines end with a space * `#808 <https://github.com/Kozea/WeasyPrint/issues/808>`_, `#387 <https://github.com/Kozea/WeasyPrint/issues/387>`_: Fix position of some images * `#813 <https://github.com/Kozea/WeasyPrint/issues/813>`_: Don't crash when long preformatted text lines end with ``\n`` Documentation: * `#815 <https://github.com/Kozea/WeasyPrint/pull/815>`_: Add documentation about custom ``url_fetcher``

liZe added the feature New feature that should be supported label Jan 21, 2019

liZe changed the title ~~box-decoration-break~~ Handle box-decoration-break Jan 21, 2019

liZe added this to the 46 milestone Feb 20, 2019

liZe added a commit that referenced this issue Mar 15, 2019

Make broken boxes fill the empty space at the end of the page

bceeab2

Related to #771. Fixes http://test.weasyprint.org/suite-css21/chapter13/section2/test7/

liZe added a commit that referenced this issue Mar 15, 2019

Add test for box-decoration-break

468e6fe

Related to #771.

liZe added a commit that referenced this issue Mar 15, 2019

Fix box-decoration-text for inline boxes

3943e67

And add related tests of course! Related to #771.

liZe closed this as completed in 2fc8f39 Mar 19, 2019

liZe mentioned this issue Mar 20, 2019

CSS Line Breaks/New Line doesn't work for non-latin chars #828

Closed

liZe added a commit that referenced this issue Mar 20, 2019

Respect bottom margin/border/padding with box-decoration-break:clone

7b53d0e

Related to #771.

liZe mentioned this issue May 14, 2019

[RFC] using Weasyprint to generate pdf OCA/reporting-engine#254

Closed

liZe added a commit that referenced this issue Jul 18, 2019

Remove useless TODO

abcd386

This TODO has been fixed with #771.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle box-decoration-break #771

Handle box-decoration-break #771

stolzweb commented Jan 18, 2019 •

edited

Loading

liZe commented Jan 21, 2019

liZe commented Feb 27, 2019

liZe commented Feb 28, 2019

liZe commented Mar 15, 2019 •

edited

Loading

liZe commented Mar 18, 2019

stolzweb commented Mar 19, 2019

liZe commented Mar 20, 2019

liZe commented Mar 20, 2019

stolzweb commented Mar 20, 2019 via email

liZe commented Mar 20, 2019

stolzweb commented Mar 20, 2019 via email

stolzweb commented May 31, 2019 via email

Handle box-decoration-break #771

Handle box-decoration-break #771

Comments

stolzweb commented Jan 18, 2019 • edited Loading

liZe commented Jan 21, 2019

liZe commented Feb 27, 2019

liZe commented Feb 28, 2019

liZe commented Mar 15, 2019 • edited Loading

liZe commented Mar 18, 2019

stolzweb commented Mar 19, 2019

liZe commented Mar 20, 2019

liZe commented Mar 20, 2019

stolzweb commented Mar 20, 2019 via email

liZe commented Mar 20, 2019

stolzweb commented Mar 20, 2019 via email

stolzweb commented May 31, 2019 via email

stolzweb commented Jan 18, 2019 •

edited

Loading

liZe commented Mar 15, 2019 •

edited

Loading