Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incomplete pypi tarballs: test_draw, test_layout missing #1247

Closed
FelixSchwarz opened this issue Nov 8, 2020 · 2 comments
Closed

incomplete pypi tarballs: test_draw, test_layout missing #1247

FelixSchwarz opened this issue Nov 8, 2020 · 2 comments
Labels
bug Existing features not working as expected
Milestone
52.2

Comments

@FelixSchwarz
Copy link
Contributor

WeasyPrint-52.1.tar.gz seems to be incomplete. test_draw and test_layout are not present in the pypi tarball leading to test failures.
liZe added a commit that referenced this issue Nov 23, 2020
@liZe
Merge pull request #1248 from FelixSchwarz/add-missing-test-resources
1772b95 
include missing test data (#1247)
@liZe
Copy link
Member

liZe commented Nov 23, 2020

Fixed by #1248.

@liZe liZe closed this as completed Nov 23, 2020
@liZe liZe added the bug Existing features not working as expected label Nov 23, 2020
@liZe liZe added this to the 52.2 milestone Nov 23, 2020
liZe pushed a commit that referenced this issue Nov 25, 2020
@FelixSchwarz @liZe
include missing test data (#1247)
e4f4fb6
@eli-schwartz
Copy link
Contributor

Note that using packages = find: is probably less fragile...

liZe added a commit that referenced this issue Dec 6, 2020
@liZe
Packaging!
4f82a4a 
Related to #1247, #1232.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Existing features not working as expected
Projects
None yet
Milestone
52.2
Development

No branches or pull requests
3 participants
@FelixSchwarz @liZe @eli-schwartz