Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prohibited using of zero and negative filed number in ProtoNumber and zero field numbers in input bytes #2766

Merged
merged 9 commits into from
Aug 23, 2024
Merged

Prohibited using of zero and negative filed number in ProtoNumber and zero field numbers in input bytes #2766

merged 9 commits into from
Aug 23, 2024

Commits on Aug 23, 2024

  1. Implemented skipping of filed with proto Id=0 if it missed in the des… 

    …criptor

Also optimized skipping of size delimited fields - removed the creation of an byte array in case of skipping

Fixes #2649
    @shanshin
    shanshin committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b712494 View commit details
    Browse the repository at this point in the history

  2. Prohibited using of zero and negative filed number in ProtoNumber and… 

    … zero field numbers in input bytes

Fixes #1566
    @shanshin
    shanshin committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c5c5d9f View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Leonid Startsev <[email protected]>
    @shanshin @sandwwraith
    shanshin and sandwwraith committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    49c8a93 View commit details
    Browse the repository at this point in the history

  4. ~review fixes

    @shanshin
    shanshin committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    18b4846 View commit details
    Browse the repository at this point in the history

  5. ~fixes

    @shanshin
    shanshin committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    27f5ccf View commit details
    Browse the repository at this point in the history

  6. ~fixes

    @shanshin
    shanshin committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    d9297f3 View commit details
    Browse the repository at this point in the history

  7. Update formats/protobuf/commonMain/src/kotlinx/serialization/protobuf… 

    …/internal/Helpers.kt

Co-authored-by: Leonid Startsev <[email protected]>
    @shanshin @sandwwraith
    shanshin and sandwwraith authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    5e6a068 View commit details
    Browse the repository at this point in the history

  8. ~review fixes

    @shanshin
    shanshin committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    79b8c12 View commit details
    Browse the repository at this point in the history

  9. ~fixes

    @shanshin
    shanshin committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    babc823 View commit details
    Browse the repository at this point in the history