Fix Flow.timeout swallowing the channel closure exception
#4072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
approved these changes
Mar 18, 2024
| @@ -394,6 +394,7 @@ private fun <T> Flow<T>.timeoutInternal( | |||
| value.onSuccess { | |||
| downStream.emit(it) | |||
| }.onClosed { | |||
| it?.let { throw it } | |||
There was a problem hiding this comment.
Is it correct that the reason this issue manifested itself is our fusing optimization?
There was a problem hiding this comment.
Oh, it boils down to the following:
val job = Job()
val produce = produce<Int>(job) { close(TestException()) }
(produce as Job).join()
job.isCancelled // False
Which makes sense for produce specifically (when it's used as a standalone coroutine builder), but not much when used as part of the flow machinery
There was a problem hiding this comment.
Also, kind of confusing semantics-wise: close with a cause fails the channel, and when a coroutine fails, the channel fails as well. Yet the channel failure on its now does not represent failure.
dkhalanskyjb
added a commit
that referenced
this pull request
Mar 25, 2024
Fix `Flow.timeout` swallowing the channel closure exception (#4072) Was merged into `master` instead of `develop` by mistake.
knisht
pushed a commit
to JetBrains/intellij-deps-kotlinx.coroutines
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4071