Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dokka to 1.9.20 #4057

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Update Dokka to 1.9.20 #4057

merged 1 commit into from
Mar 28, 2024

Conversation

whyoleg
Copy link
Contributor

@whyoleg whyoleg commented Mar 5, 2024

No issues comparing to Dokka 1.9.10. knit tasks works

@whyoleg whyoleg self-assigned this Mar 5, 2024
@qwwdfsad qwwdfsad requested a review from dkhalanskyjb March 6, 2024 13:25
@dkhalanskyjb
Copy link
Collaborator

The changes seem beneficial; only one place caught my eye. In kotlinx-coroutines-debug/build/dokka/htmlPartial/kotlinx.coroutines.debug/-debug-probes/print-job.html, in the old version, there's an <a href for the Job reference, but with the new version, there's some <dokka-template-command instead. Is this expected?

@whyoleg
Copy link
Contributor Author

whyoleg commented Mar 26, 2024

htmlPartial tasks outputs are not relevant and could change from release to release, as they are like intermediate partial result of Dokka for single module in multi-module projects.
So yes, something could change there. Most likely in this case, resolving of the links was changed (and most likely fixed) as per Kotlin/dokka#2272 - as in kotlinx.coroutines there is exists the same package in both core and debug artefact.

If you still do want to check the difference, it will be more correct to check multi-module result which is produced in build/dokka/htmlMultiModule

@dkhalanskyjb
Copy link
Collaborator

Oh, I see, thanks! Didn't know about these fine details. Looking briefly at dokka/htmlMultiModule, I do indeed see nothing suspicious.

@dkhalanskyjb dkhalanskyjb merged commit f9a4545 into master Mar 28, 2024
1 check passed
@dkhalanskyjb dkhalanskyjb deleted the dokka-1.9.20 branch March 28, 2024 10:27
knisht pushed a commit to JetBrains/intellij-deps-kotlinx.coroutines that referenced this pull request Apr 15, 2024
mikegr pushed a commit to mikegr/kotlinx.coroutines that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants