Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI property ignored in version resolution #3663

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Fix CLI property ignored in version resolution #3663

merged 2 commits into from
Jun 1, 2023

Conversation

Badya
Copy link
Contributor

@Badya Badya commented Mar 6, 2023

Cherry pick from kotlin-community/dev

@Badya Badya requested review from qwwdfsad and woainikk March 6, 2023 16:45
Badya referenced this pull request Mar 6, 2023
@Badya
Fix CLI property ignored in version resolution
2a956a2
@qwwdfsad qwwdfsad changed the base branch from master to develop May 3, 2023 08:50
@qwwdfsad
Copy link
Collaborator

qwwdfsad commented May 3, 2023

Could you please elaborate on what it is needed for?

@Badya
Copy link
Contributor Author

Badya commented May 3, 2023

Could you please elaborate on what it is needed for?

Without this change, when we pass gradle property via CLI, e.g. kotlin_version for K2 tests on CI, it will ignore the CLI property because it reads gradle.properties directly from the file instead of using a gradle property resolution mechanism.

@qwwdfsad qwwdfsad merged commit 84080aa into develop Jun 1, 2023
@qwwdfsad qwwdfsad deleted the badya/fix-build-cli-property branch June 1, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwwdfsad qwwdfsad qwwdfsad approved these changes

@woainikk woainikk Awaiting requested review from woainikk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Badya @qwwdfsad