Reduce reachable references of disposed invokeOnTimeout handle #3353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cannot write a proper unit test though, but we've discussed it with K/N folks and it seems like there is a potential API for that |
whyoleg
reviewed
Jun 29, 2022
dkhalanskyjb
approved these changes
Jun 30, 2022
Comment on lines
+53
to
+55
| val disposableBlock = DisposableBlock(block) | ||
| worker.executeAfter(timeMillis.toMicrosSafe(), disposableBlock) | ||
| return disposableBlock |
There was a problem hiding this comment.
Suggested change
| val disposableBlock = DisposableBlock(block) | |
| worker.executeAfter(timeMillis.toMicrosSafe(), disposableBlock) | |
| return disposableBlock | |
| DisposableBlock(block).also { worker.executeAfter(timeMillis.toMicrosSafe(), it) } |
The variable name does not seem to be informative.
Co-authored-by: dkhalanskyjb <[email protected]>
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
…n#3353) * Reduce reachable references of disposed invokeOnTimeout handle Fixes Kotlin#3351
pablobaxter
added a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
…to baxter/upstream-flow-timeout * origin/baxter/upstream-flow-timeout: (328 commits) Commit API dump Cleanup API, update knit Fix typo in runTest method docs (Kotlin#3417) Update coroutines-and-channels.md (Kotlin#3410) chore: update the website's release step (Kotlin#3397) ktl-695 chore: support Dokka HTML customization (Kotlin#3388) update: KT-50122 adding kotlinx.dependencies Improve bump-version.sh (Kotlin#3365) Fix documentation for `DEBUG_PROPERTY_VALUE_OFF` (Kotlin#3389) feat: moving coroutines hands-on to docs (Kotlin#3369) Version 1.6.4 Improve CoroutineDispatcher documentation (Kotlin#3359) Update binary compatibility validator to 0.11.0 (Kotlin#3362) Add a scope for launching background work in tests (Kotlin#3348) Fix debug module publication with shadow plugin (Kotlin#3357) Comply with Subscriber rule 2.7 in the `await*` impl (Kotlin#3360) Update readme (Kotlin#3343) Reduce reachable references of disposed invokeOnTimeout handle (Kotlin#3353) breakleg; knit validation fix Additional comment in CoroutineScheduler ... # Conflicts: # README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3351