CoroutinesTimeout for JUnit5 #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
requested changes
Mar 24, 2021
kotlinx-coroutines-debug/src/junit/junit5/CoroutinesTimeoutExtension.kt
Outdated
Show resolved
Hide resolved
kotlinx-coroutines-debug/test/junit5/CoroutinesTimeoutSimpleTest.kt
Outdated
Show resolved
Hide resolved
dkhalanskyjb
force-pushed
the
junit5-CoroutinesTimeout
branch
2 times, most recently
from
fbefe36 to
54da484
Compare
qwwdfsad
reviewed
Apr 22, 2021
| @@ -38,6 +41,12 @@ if (rootProject.ext.jvm_ir_enabled) { | |||
| } | |||
| } | |||
|
|
|||
| java { | |||
There was a problem hiding this comment.
Doesn't seem to be necessary for the latest develop where we have 1.8 target
There was a problem hiding this comment.
I attempted to remove this block, but then the build was failing. I managed to fix the build of this subproject by adding
tasks.withType(JavaCompile) {
targetCompatibility = JavaVersion.VERSION_1_8
}However, then kotlinx-coroutines-test also required targetCompatibility set. At that point, I stopped. Do you think this should be pursued further?
There was a problem hiding this comment.
I think that's enough, thanks for checking it
|
|
||
| private fun tryPassDebugProbesOwnership() = debugProbesOwnershipPassed.compareAndSet(false, true) | ||
|
|
||
| private val isDebugProbesOwnershipPassed |
kotlinx-coroutines-debug/src/junit/junit5/CoroutinesTimeoutExtension.kt
Outdated
Show resolved
Hide resolved
As implemented, now DebugProbes will be installed before the first constructor of a test class that uses CoroutinesTimeout is invoked, and uninstalled during the cleanup of the extension.
Instead, another interface is implemented that resembles the one provided for JUnit4 and does allow such configuration.
1. A case where extension instances run concurrently and use the same extension context or where an extension instance is run on several methods concurrently is handled, even though it's unclear whether such things could happen. 2. Using CoroutinesTimeout via annotation no longer needs write access to the resource lock, meaning that tests annotated with it don't have to run sequentially. 3. Better documentation for the now-complex logic.
dkhalanskyjb
force-pushed
the
junit5-CoroutinesTimeout
branch
from
54da484 to
bb5216c
Compare
qwwdfsad
approved these changes
Apr 23, 2021
| @@ -38,6 +41,12 @@ if (rootProject.ext.jvm_ir_enabled) { | |||
| } | |||
| } | |||
|
|
|||
| java { | |||
There was a problem hiding this comment.
I think that's enough, thanks for checking it
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2197.