Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more documentation about a case where .offer() can throw #1824

Closed
wants to merge 3 commits into from
Closed

Add more documentation about a case where .offer() can throw #1824

wants to merge 3 commits into from

Conversation

martinbonnin
Copy link

@martinbonnin martinbonnin commented Feb 21, 2020 •
edited
Loading

Calling offer on a closed channel will throw. See #974.

Make this explicit in the code snippets.

@martinbonnin martinbonnin mentioned this pull request Feb 21, 2020
Closed
@elizarov
Copy link
Contributor

elizarov commented Mar 13, 2020 •
edited
Loading

This PR is now in conflict since the corresponding callback flow example had been updated.

@LouisCAD
Copy link
Contributor

Also, maybe it makes sense to change the target branch to develop?

@martinbonnin
Copy link
Author

It looks like develop has the try/catch already: https://github.com/Kotlin/kotlinx.coroutines/blob/develop/kotlinx-coroutines-core/common/src/flow/Builders.kt#L293

(from 4aa3880#diff-57fe61dee82c96bd815e588a3af51853R286)

I'm closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LouisCAD LouisCAD LouisCAD requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinbonnin @elizarov @LouisCAD