-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Tentative implementation and name, no docs yet Fixes #576
- Loading branch information
Showing
6 changed files
with
105 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/* | ||
* Copyright 2016-2018 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license. | ||
*/ | ||
|
||
package kotlinx.coroutines.experimental | ||
|
||
import kotlin.coroutines.experimental.* | ||
|
||
@Suppress("FunctionName") | ||
public fun SupervisorJob(parent: Job? = null) : Job = SupervisorJobImpl(parent) | ||
|
||
public suspend fun <R> supervisorScope(block: suspend CoroutineScope.() -> R): R { | ||
// todo: optimize implementation to a single allocated object | ||
// todo: fix copy-and-paste with coroutineScope | ||
val owner = SupervisorCoroutine<R>(coroutineContext) | ||
owner.start(CoroutineStart.UNDISPATCHED, owner, block) | ||
owner.join() | ||
if (owner.isCancelled) { | ||
throw owner.getCancellationException().let { it.cause ?: it } | ||
} | ||
val state = owner.state | ||
if (state is CompletedExceptionally) { | ||
throw state.cause | ||
} | ||
@Suppress("UNCHECKED_CAST") | ||
return state as R | ||
|
||
} | ||
|
||
private class SupervisorJobImpl(parent: Job?) : JobSupport(true) { | ||
init { initParentJobInternal(parent) } | ||
override val onFailComplete get() = true | ||
override val handlesException: Boolean get() = false | ||
override fun childFailed(cause: Throwable): Boolean = false | ||
} | ||
|
||
private class SupervisorCoroutine<R>( | ||
parentContext: CoroutineContext | ||
) : AbstractCoroutine<R>(parentContext, true) { | ||
override fun childFailed(cause: Throwable): Boolean = false | ||
} |
58 changes: 58 additions & 0 deletions
58
common/kotlinx-coroutines-core-common/test/SupervisorTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
/* | ||
* Copyright 2016-2018 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license. | ||
*/ | ||
|
||
@file:Suppress("NAMED_ARGUMENTS_NOT_ALLOWED") // KT-21913 | ||
|
||
package kotlinx.coroutines.experimental | ||
|
||
import kotlin.test.* | ||
|
||
class SupervisorTest : TestBase() { | ||
@Test | ||
fun testSupervisorJob() = runTest( | ||
unhandled = listOf( | ||
{ it -> it is TestException2 }, | ||
{ it -> it is TestException1 } | ||
) | ||
) { | ||
expect(1) | ||
val supervisor = SupervisorJob() | ||
val job1 = launch(supervisor + CoroutineName("job1")) { | ||
expect(2) | ||
yield() // to second child | ||
expect(4) | ||
throw TestException1() | ||
} | ||
val job2 = launch(supervisor + CoroutineName("job2")) { | ||
expect(3) | ||
throw TestException2() | ||
} | ||
joinAll(job1, job2) | ||
finish(5) | ||
assertTrue(job1.isFailed) | ||
assertTrue(job2.isFailed) | ||
} | ||
|
||
@Test | ||
fun testSupervisorScope() = runTest( | ||
unhandled = listOf( | ||
{ it -> it is TestException1 }, | ||
{ it -> it is TestException2 } | ||
) | ||
) { | ||
val result = supervisorScope { | ||
launch { | ||
throw TestException1() | ||
} | ||
launch { | ||
throw TestException2() | ||
} | ||
"OK" | ||
} | ||
assertEquals("OK", result) | ||
} | ||
|
||
private class TestException1 : Exception() | ||
private class TestException2 : Exception() | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters