-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove unnecessary -keep rule for AndroidDispatcherFactory, AndroidEx…
…ceptionPreHandler R8 supports keeping and/or optimizing classes found in META-INF/services: https://b.corp.google.com/issues/120436373#comment7 The last R8 commit I can find related to ServerLoader is https://r8-review.googlesource.com/53824 (Sept 2020), so I think R8 1.6 still needs the -keep rule, but 3.0+ should not. Fixes: 3111
- Loading branch information
Showing
5 changed files
with
8 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 0 additions & 9 deletions
9
...linx-coroutines-android/resources/META-INF/com.android.tools/r8-upto-1.6.0/coroutines.pro
This file was deleted.
Oops, something went wrong.
6 changes: 6 additions & 0 deletions
6
...linx-coroutines-android/resources/META-INF/com.android.tools/r8-upto-3.0.0/coroutines.pro
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
# After R8 3.0.0 (or probably sometime before that), R8 learned how to optimize | ||
# classes mentioned in META-INF/services files, and explicitly -keeping them | ||
# disables these optimizations. | ||
# https://github.com/Kotlin/kotlinx.coroutines/issues/3111 | ||
-keep class kotlinx.coroutines.android.AndroidDispatcherFactory {*;} | ||
-keep class kotlinx.coroutines.android.AndroidExceptionPreHandler {*;} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters