Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maven plugin - correction to documentation of filters #688

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Maven plugin - correction to documentation of filters #688

merged 1 commit into from
Sep 19, 2024

Conversation

ollieabbey
Copy link
Contributor

Spotted when setting up the plugin from the docs.

filters shouldn't have another child block called filters.

Examples are already correct here and here.

shanshin
shanshin approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@shanshin shanshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shanshin shanshin merged commit eaf3a92 into Kotlin:main Sep 19, 2024
@ollieabbey ollieabbey deleted the maven_plugin_docs_filters_fix branch September 19, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanshin shanshin shanshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ollieabbey @shanshin