Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate values of benchmark configuration options #124

Closed
qurbonzoda opened this issue Jul 2, 2023 · 0 comments
Closed

Validate values of benchmark configuration options #124

qurbonzoda opened this issue Jul 2, 2023 · 0 comments

Comments

@qurbonzoda
Copy link
Collaborator

qurbonzoda commented Jul 2, 2023 •
edited
Loading

Currently, some config values are validated in :plugin (e.g., reportFormat), while some others are validated in :runtime (e.g., iterationTimeUnit). Others aren't validated at all, e.g., iterations (validated only on JVM by JMH).
All config values should be validated in :plugin.

Examples of invalid config values:

iterations = -10
iterationTimeUnit = "yes"
@wldeh wldeh mentioned this issue Jul 3, 2023
Merged
OndrejSliva pushed a commit to OndrejSliva/kotlinx-benchmark that referenced this issue Jan 10, 2024
@github-actions
Merge pull request Kotlin#124 from sureshg/dependabot/maven/org.mvnse…
d11d02d 
…arch-toolchains-maven-plugin-4.5.0

build(deps): bump toolchains-maven-plugin from 4.4.0 to 4.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qurbonzoda