Remove targetRotation setter api (#454) #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliabeliaeva
suggested changes
Sep 26, 2022
dataset/src/androidMain/kotlin/org/jetbrains/kotlinx/dl/dataset/preprocessing/Preprocessing.kt
Outdated
Show resolved
Hide resolved
onnx/src/androidMain/kotlin/org/jetbrains/kotlinx/dl/api/inference/onnx/ONNXModels.kt
Outdated
Show resolved
Hide resolved
onnx/src/androidMain/kotlin/org/jetbrains/kotlinx/dl/api/inference/onnx/ONNXModels.kt
Outdated
Show resolved
Hide resolved
onnx/src/androidMain/kotlin/org/jetbrains/kotlinx/dl/api/inference/onnx/ONNXModels.kt
Outdated
Show resolved
Hide resolved
...c/androidMain/kotlin/org/jetbrains/kotlinx/dl/dataset/preprocessing/imageproxy/imageUtlls.kt
Outdated
Show resolved
Hide resolved
ermolenkodev
force-pushed
the
454
branch
2 times, most recently
from
2b66664
to
ab71840
Compare
juliabeliaeva
approved these changes
Sep 29, 2022
...n/kotlin/org/jetbrains/kotlinx/dl/api/inference/onnx/classification/ImageRecognitionModel.kt
Outdated
Show resolved
Hide resolved
...droidMain/kotlin/org/jetbrains/kotlinx/dl/api/inference/onnx/objectdetection/SSDLikeModel.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/org/jetbrains/kotlinx/dl/api/inference/onnx/classification/ImageRecognitionModel.kt
Outdated
Show resolved
Hide resolved
…input (Kotlin#454) * Extend the ModelHub's models with an API that accepts ImageProxy as an input. * Now user not required to set targetRotation property by hand The rotation operation is quite expensive, so it's beneficial to make a rotation after resizing, although it makes API less intuitive.
Introduced in PR Kotlin#459
* Introduce doWithRotation extension function to reduce code duplication * Move extension functions to the base classes (e.g. SinglePoseDetectionModelBase instead SinglePoseDetectionModel) Co-authored-by: Julia Beliaeva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the ModelHub's models with an API that accepts ImageProxy as an input.
Now user not required to set targetRotation property by hand
The rotation operation is quite expensive, so it's beneficial to make a rotation after resizing, although it makes API less intuitive.