Added Dot Layer #275
Merged
Added Dot Layer #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaleslaw
requested changes
Nov 15, 2021
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/merge/Dot.kt
Show resolved
Hide resolved
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/merge/Dot.kt
Outdated
Show resolved
Hide resolved
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/merge/Dot.kt
Outdated
Show resolved
Hide resolved
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/merge/Dot.kt
Outdated
Show resolved
Hide resolved
|
Hi @therealansh do you have plans to fix a review comments here? It will be great to merge it in December in the codebase |
|
Added the docs! I have removed the Dot Test case for now. I'll be doing it in the PR for #276. Should i add a TODO as well for refactoing l2Normalize and batchDot for future refactoring? |
|
No needs to add TODO, I make this refactoring in the nearest future |
|
Great, now we have DOT! |
|
Hey @zaleslaw , while writing test cases for at out = MatMul.create(scope, x2, y2, MatMul.transposeA(adjX), MatMul.transposeB(adjY))in batchDot. Can you review it once I cannot understand what the issue is about? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Dot layer and closes #144. @zaleslaw would you mind reviewing it for this initial commit. I am still working on some test cases.