Add RepeatVector layer #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
� Conflicts: � api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/inference/keras/ModelSaver.kt
avan1235
suggested changes
Jun 18, 2021
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/reshaping/RepeatVector.kt
Outdated
Show resolved
Hide resolved
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/reshaping/RepeatVector.kt
Outdated
Show resolved
Hide resolved
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/reshaping/RepeatVector.kt
Outdated
Show resolved
Hide resolved
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/reshaping/RepeatVector.kt
Outdated
Show resolved
Hide resolved
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/reshaping/RepeatVector.kt
Outdated
Show resolved
Hide resolved
api/src/test/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/RepeatVectorLayerTest.kt
Outdated
Show resolved
Hide resolved
api/src/test/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/RepeatVectorLayerTest.kt
Outdated
Show resolved
Hide resolved
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/reshaping/RepeatVector.kt
Show resolved
Hide resolved
api/src/test/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/RepeatVectorLayerTest.kt
Outdated
Show resolved
Hide resolved
api/src/test/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/RepeatVectorLayerTest.kt
Outdated
Show resolved
Hide resolved
|
@avan1235 thanks a lot for your comments. This is my first time contributing to an open source project and your comments were really thoughtful, will make changes and keep in mind for future contributions. |
- added missing require check in init block of RepeatVector - updated docs - reformatted code - housekeeping
- change require message in computeOutputShape - used inputShape.size(...) for creating shape - removed author tag
zaleslaw
requested changes
Jun 23, 2021
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/inference/keras/ModelSaver.kt
Show resolved
Hide resolved
api/src/test/kotlin/org/jetbrains/kotlinx/dl/api/core/layer/RepeatVectorLayerTest.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| // TODO: generalise this for Layer, see https://github.com/JetBrains/KotlinDL/issues/145 | ||
| private operator fun RepeatVector.invoke(input: Array<FloatArray>): Output<Float> = Ops.create().let { tf -> |
There was a problem hiding this comment.
maybe you could make a util internal extension function for the Layer class?
There was a problem hiding this comment.
maybe I could, u mean as described in #145 ?
What should I do for now though, remove the function?
There was a problem hiding this comment.
So at this moment, you could leave it as is, I suppose.
The improvement related to #145 should be implemented in the separate PR and discussed with other contributors faced with this problem.
- save trainability status - renamed tests
zaleslaw
added
LGTM
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.