-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Merge Layer Test Cases #276
Comments
Yes, a lot of tests are missed for many layers. It will be great to add them to the test suite |
Hey @zaleslaw, would it be nice if I put Merge tests in one file as the |
Yes, put it into one file |
Hey @zaleslaw , have a look at this test case, this is from tf official doc yet it fails, AFAIK the @Test
fun average(){
val x1 = Array(2){FloatArray(2){1f} }
val x2 = Array(2){FloatArray(2){0f} }
val input = arrayOf(x1,x2)
val expected = Array(2){FloatArray(2){0.5f} }
assertLayerOutputIsCorrect(Average(), input,expected)
} |
Thanks for the note @therealansh ! Probably the |
Hey @zaleslaw, I guess the bug is in |
KotlinDL is right now does not have Merge Layer test cases like
Add
,Concatenate
,Multiply
and so on. I guess addition of test cases will be great. Also what do you think about refactoring and organising the layer test cases directory @zaleslaw?The text was updated successfully, but these errors were encountered: