-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spark 3.3.0 support, gradle, and automate releasing all versions at once #168
Conversation
Maybe also find a way for #166 here |
…All packages will be pacakge_scala.version_spark.version.
# Conflicts: # core/src/main/scala/org/jetbrains/kotlinx/spark/extensions/VarargUnwrapper.scala # kotlin-spark-api/src/main/kotlin/org/jetbrains/kotlinx/spark/api/UDFRegister.kt # kotlin-spark-api/src/main/kotlin/org/jetbrains/kotlinx/spark/api/UserDefinedAggregateFunction.kt # kotlin-spark-api/src/main/kotlin/org/jetbrains/kotlinx/spark/api/UserDefinedFunction.kt # kotlin-spark-api/src/main/kotlin/org/jetbrains/kotlinx/spark/api/UserDefinedFunctionVararg.kt # kotlin-spark-api/src/main/kotlin/org/jetbrains/kotlinx/spark/api/UserDefinedFunctions.kt # kotlin-spark-api/src/test/kotlin/org/jetbrains/kotlinx/spark/api/UDFRegisterTest.kt # kotlin-spark-api/src/test/kotlin/org/jetbrains/kotlinx/spark/api/UDFTest.kt
# Conflicts: # core/pom.xml # dummy/pom.xml # examples/pom.xml # jupyter/pom.xml # kotlin-spark-api/pom.xml # kotlin-spark-api/src/test/kotlin/org/jetbrains/kotlinx/spark/api/UDFRegisterTest.kt # pom.xml # pom_parent.xml # scala-tuples-in-kotlin/pom.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the structure, but I would prefer to have this split into couple commits — one for migration maven—gradle, one for tests fixes, one for jcp maybe
5ee986b
to
ddd9eb9
Compare
It's difficult to squash the older commits since this is already a combination of 2 or 3 pull requests. (The gradle branch, spark 3.0 support branch, main branch). Squashing with 2+ parents is impossible afaik |
922f3ac
to
d4fedf7
Compare
…dlew command. JCP is used for compatibilty issues across scala- and spark versions. JPC compatibility with IntelliJ is fixed. gradlew-all-versions can be used to push commands to all versions, gh actions uses matrix to deploy/build all of them. kotlin 1.7.10, updated readme.
@asm0dey I want to update the wip commit message to:
But githut rejects my push for some reason. Could you try to rename it to this? |
d4fedf7
to
c512a56
Compare
#167