Readme streaming (1.1.0 release) #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… time in jupyter cells, working on streams being allowed to be interrupted in jupyter
Found broken jupyter streaming test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the readme examples link.
Fixes printlns not working the second time a jupyter cell is run.
Attempted to fix when a cell with streaming is interrupted. This needs Kotlin/kotlin-jupyter#369.
@asm0dey Also found one broken jupyter streaming test which I disabled for now. It works fine without jupyter, but you know how difficult it is to test streaming... We can leave it disabled for the release and look at it later since Jupyter support is still experimental for now.