Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuple first #144

Merged
merged 25 commits into from
Apr 11, 2022
Merged

Tuple first #144

merged 25 commits into from
Apr 11, 2022

Conversation

Jolanrensen
Copy link
Collaborator

Implements some version of my old library: https://github.com/Jolanrensen/ScalaTuplesInKotlin/tree/main

There is some speed loss when working with functions that prefer Arities and Pairs over Tuples since those are what Spark is optimized for. Putting Tuples first will thus probably lower the confusion of users and increase performance :)

Sort of follow up from #76

@Jolanrensen
Copy link
Collaborator Author

Jolanrensen commented Mar 29, 2022

Maybe takeN(), dropN() (and takeLastN(), dropLastN()) and splitAsN() could also be added, since they are added in Scala 3, similar to zip.
map {} might also be a simple one.

Not sure if this is becoming overkill or still useful XD

@asm0dey
Copy link
Contributor

asm0dey commented Mar 31, 2022

LGTM, but I cant say that I've carefully reviews everything generated

@Jolanrensen
Copy link
Collaborator Author

LGTM, but I cant say that I've carefully reviews everything generated

I'll just check how performance of IntelliJ is while working on something else when having these tuples present in the project. If that's fine I'll merge it :)

@asm0dey
Copy link
Contributor

asm0dey commented Apr 1, 2022

Nice plan!

@Jolanrensen
Copy link
Collaborator Author

Jolanrensen commented Apr 1, 2022

Performance is way better in a separate module :) tried it with the streaming functions. Consecutive builds are way faster than full ones. The only downside is that now dokka won't include the tuples. We could publish it to a separate docs branch while we haven't switched to gradle yet? I thought gradle did support multi-module dokka

@Jolanrensen Jolanrensen merged commit d0ae7fb into spark-3.2 Apr 11, 2022
@Jolanrensen Jolanrensen added this to the 1.1.0 milestone May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants