added encoders 3.2 #134
Merged
added encoders 3.2 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction taking a SparkConf
Adds sc JavaSparkContext to KSparkSession
…king) added tests for: Instant datatype, duration, period, binary, and others added datatypes: ByteArray (BinaryType), CalendarInterval, Nothing (All three not yet working)
… tests, removed streaming example
|
Not sure why serializing ByteArrays with knownTypes doesn't work actually... it should just work |
… some refactoring. still trying to get serializing of binary to work
|
okay the Period encoder seems to be broken by Spark itself. Other than that, all 3.2 stuff seems to be working and the tests actually test the contents now instead of just showing it |
|
Oh right and the KotlinReflection scala file is now more readable :) |
asm0dey
reviewed
Feb 23, 2022
kotlin-spark-api/3.2/src/main/kotlin/org/jetbrains/kotlinx/spark/api/ApiV1.kt
Show resolved
Hide resolved
asm0dey
reviewed
Feb 23, 2022
| dataset.collectAsList().let { | ||
| it[0] shouldBe Period.ZERO | ||
|
|
||
| // TODO this is also broken in Scala. It reports a Period of 0 instead of 2 days |
There was a problem hiding this comment.
Please link relevant JIRA ticket
There was a problem hiding this comment.
https://issues.apache.org/jira/browse/SPARK-38317 Apparently it's expected behavior, strange
Added kotlin official code style prop for later
Rdd related helpers
added force_orphan
Apparently this is expected behavior: https://issues.apache.org/jira/browse/SPARK-38317
…king) added tests for: Instant datatype, duration, period, binary, and others added datatypes: ByteArray (BinaryType), CalendarInterval, Nothing (All three not yet working)
… some refactoring. still trying to get serializing of binary to work
…coders-and-data-types # Conflicts: # kotlin-spark-api/3.2/src/test/kotlin/org/jetbrains/kotlinx/spark/api/ApiTest.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duration, Period, ByteArray (Binary, now actually working)
added tests for: Instant datatype, duration, period, binary, and others
added datatypes: ByteArray (BinaryType), CalendarInterval, Nothing (All three not yet working)
metioned: #131
WIP