Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dokka Gradle task cacheable #830

Closed
wants to merge 1 commit into from
Closed

Make dokka Gradle task cacheable #830

wants to merge 1 commit into from

Conversation

devisnik
Copy link
Contributor

@devisnik devisnik commented May 4, 2020

adds support for local and remote caching to DokkaTask.

addresses #453

@sellmair
Copy link
Member

sellmair commented Jul 8, 2020

Hey @devisnik, thanks for your contribution 👍
Would you be able to rebase this on our latest dev-0.11.0 branch?

@sellmair sellmair requested review from kamildoleglo and sellmair and removed request for kamildoleglo July 8, 2020 05:31
@sellmair sellmair self-assigned this Jul 8, 2020
@sellmair sellmair added enhancement An issue for a feature or an overall improvement awaiting response An issue/PR that cannot be completed without additional information or a discussion labels Jul 8, 2020
@Kordyjan Kordyjan force-pushed the master branch 2 times, most recently from 2baf097 to 0d0d41f Compare July 9, 2020 07:59
@devisnik
Copy link
Contributor Author

devisnik commented Aug 5, 2020

Sorry for the late reply.
I'll look into redoing the changes onto dev-0.11.0. Seems the test infrastructure has changed quite a bit on that branch.

@sellmair
Copy link
Member

sellmair commented Aug 5, 2020

Please also check the Gradle maintenance branch! It might make sense to wait for that and adjust accordingly if there are still issues!

@devisnik
Copy link
Contributor Author

devisnik commented Aug 5, 2020

@sellmair Do you mean gradle-plugin-maintenance ?
I have a working version based on dev-0.11.0 now. Do you want me to PR that? Or should the change be based on gradle-plugin-maintenance ?

@sellmair
Copy link
Member

Yes, I mean that branch.
But I think this should be the plan: We might want to merge #1194 first and then adapt your changes on top of it ☺️

@sellmair sellmair removed the awaiting response An issue/PR that cannot be completed without additional information or a discussion label Aug 11, 2020
@devisnik devisnik mentioned this pull request Aug 11, 2020
Closed
@devisnik
Copy link
Contributor Author

@sellmair Sounds good to me. 😄
I've created #1296 for the changes on dev-0.11.0. We might want to adapt that one after #1194 has been merged.

Should we close this one?

@sellmair
Copy link
Member

Thanks for the effort. We are actually now branching from/targeting master instead of dev-0.11.0, but those branches are not drastically different at the moment.

But there is no need of closing this right now. I will take care of it once the Gradle Plugin changes are merged ☺️

@keturn
Copy link

keturn commented Aug 5, 2021

Superseded by #1905?

@vmishenev vmishenev force-pushed the master branch 2 times, most recently from de135ce to 4397c96 Compare December 7, 2021 17:10
@IgnatBeresnev IgnatBeresnev added the runner: Gradle plugin An issue/PR related to Dokka's Gradle plugin label Oct 12, 2022
@aSemy aSemy mentioned this pull request Oct 12, 2022
Closed
@eskatos
Copy link
Contributor

eskatos commented Jan 14, 2023

Can't this be closed?

@nyila nyila mentioned this pull request Jan 15, 2023
Closed
@IgnatBeresnev
Copy link
Member

It does indeed look like it was re-implemented in #1905, so I'll be closing the PR. Thank you for your effort though!

Can't this be closed?

I'm reluctant to close old PRs on the basis that they are old, it's rude and we might miss out on useful changes, but it takes time to verify and revive them, and we haven't had time lately. It's on our list though.

If you see similarly stale PRs/issues that have been implemented, please point it out, I'd be happy to have a closer look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sellmair sellmair Awaiting requested review from sellmair

@kamildoleglo kamildoleglo Awaiting requested review from kamildoleglo

Assignees

@sellmair sellmair

Labels
enhancement An issue for a feature or an overall improvement runner: Gradle plugin An issue/PR related to Dokka's Gradle plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devisnik @sellmair @keturn @eskatos @IgnatBeresnev