KT-64377 - Update Dokka build properties #3420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-enko
commented
Dec 18, 2023
IgnatBeresnev
approved these changes
Dec 18, 2023
whyoleg
approved these changes
Dec 19, 2023
| } | ||
| ) | ||
|
|
||
| val tryK2: Provider<Boolean> = |
There was a problem hiding this comment.
BTW: while we are here, if this is used only in integration tests, may be it's better to rename it to integration_test.useK2 instead of using the same flag which is used to run dokka with K2 - now it feels a bit confusing IMO
There was a problem hiding this comment.
Good idea. Just to be clear the full name will be org.jetbrains.dokka.integration_test.useK2
There was a problem hiding this comment.
Note: TC config should be updated to use this new property - after merge to master only
adam-enko
changed the title
|
I've rebased this branch to remove #3419 EDIT: Or not... git is hard. |
rename 'tryK2' to 'useK2' for integration tests
Tapchicoma
approved these changes
Jan 12, 2024
adam-enko
merged commit 20e0984
into
Kotlin:KT-64377/update-integration-test-build-config
7 of 8 checks passed
adam-enko
added a commit
that referenced
this pull request
Jan 19, 2024
…toring (#3422) * KT-64377 - remove gradle wrapper files for integration test projects (#3418) * remove Gradle wrapper files for integration test projects * .gitignore Gradle wrapper files * refactor integration test properties to use DokkaBuildProperties utility (#3420) rename 'tryK2' to 'useK2' for integration tests * disable explicit API mode in non-published integration-test utilities (#3428)
adam-enko
added
the
infrastructure
vmishenev
pushed a commit
that referenced
this pull request
Mar 20, 2024
…toring (#3422) * KT-64377 - remove gradle wrapper files for integration test projects (#3418) * remove Gradle wrapper files for integration test projects * .gitignore Gradle wrapper files * refactor integration test properties to use DokkaBuildProperties utility (#3420) rename 'tryK2' to 'useK2' for integration tests * disable explicit API mode in non-published integration-test utilities (#3428)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates a couple of integration test properties to use the DokkaBuildProperties class.
Depends on
KT-64377 - automatically download and setup Android SDK in Gradle Integration Test #3419