Add Gradle integration test for wasm-js and wasm-wasi targets
#3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmishenev
requested review from
IgnatBeresnev,
whyoleg and
igoriakovlev
and removed request for
whyoleg and
igoriakovlev
igoriakovlev
approved these changes
Nov 3, 2023
| } | ||
|
|
||
| // HACK: some dependencies (coroutines -wasm0 and atomicfu -wasm0) reference deleted *-dev libs | ||
| configurations.all { |
There was a problem hiding this comment.
You do not need it becase new versions without deprecated dependencies were published.
Please check latest versions here.
| # Copyright 2014-2023 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license. | ||
| # | ||
|
|
||
| dokka_it_kotlin_version=1.9.20-RC2 |
There was a problem hiding this comment.
1.9.20 was published. I suggest to use it.
whyoleg
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
LGTM
But, what do you think about replacing existing Wasm test instead of creating new one? Wasm is still experimental, and recently in 1.9.20 it started to using latest WasmGC opcodes, so now pre 1.9.20 built binaries will not work in recent browsers and nodejs. And so may be it doesn't make sense to have any tests for them, as eventually it will be deprecated and removed?
IgnatBeresnev
approved these changes
Nov 8, 2023
vmishenev
force-pushed
the
vmishenev/add-WasmJsWasiGradleIntegrationTest
branch
from
bb49051 to
cc0af74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.