Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KGP to 1.8.20 #2989

Merged
merged 14 commits into from
May 17, 2023
Merged

Update KGP to 1.8.20 #2989

merged 14 commits into from
May 17, 2023

Conversation

vmishenev
Copy link
Contributor

@vmishenev vmishenev commented May 1, 2023

KGP 1.8.20 have increased memory consumption in Dokka project a little (10-20%), It causes memory exhaustion of free GitHub runners in GitHub Actions. (publishing coroutines ##[debug]Node Action run completed with exit code 143 and the unit tests on Windows Native memory allocation (malloc) failed to allocate). The --no-daemon flag does not help anymore in Windows.
So stricter memory constraints have been applied to GH actions.

It is based on #2972

@vmishenev vmishenev changed the title Update KGP 1.8.20 Update KGP to 1.8.20 May 1, 2023
@vmishenev vmishenev force-pushed the update-kgp-1.8.20 branch 2 times, most recently from 8548f18 to 665f71d Compare May 1, 2023 20:34
@vmishenev vmishenev force-pushed the update-kgp-1.8.20 branch 6 times, most recently from 44fcaff to bac97d8 Compare May 4, 2023 19:11
@vmishenev vmishenev force-pushed the update-kgp-1.8.20 branch 5 times, most recently from 554e695 to e0d6f7a Compare May 5, 2023 13:32
@vmishenev vmishenev force-pushed the update-kgp-1.8.20 branch 2 times, most recently from 3345075 to 168d4e8 Compare May 8, 2023 14:00
@vmishenev vmishenev force-pushed the update-kgp-1.8.20 branch from 168d4e8 to 0b957c0 Compare May 8, 2023 14:47
@vmishenev vmishenev marked this pull request as ready for review May 8, 2023 14:59
@vmishenev vmishenev requested a review from IgnatBeresnev May 8, 2023 14:59
vmishenev added 2 commits May 11, 2023 16:00
Dokka suppresses source sets that do no have compilation since such configuration is invalid, it reports a warning or an error
@vmishenev vmishenev requested a review from IgnatBeresnev May 11, 2023 15:14
@vmishenev vmishenev requested a review from IgnatBeresnev May 17, 2023 14:27
@IgnatBeresnev
Copy link
Member

IgnatBeresnev commented May 17, 2023

I triggered thorough tests manually, but for some reason GitHub is not reporting them as pending / in progress for this PR

Let's wait for these to pass before the merge: https://github.com/Kotlin/dokka/actions/runs/5004525443

@vmishenev
Copy link
Contributor Author

vmishenev commented May 17, 2023

for some reason GitHub is not reporting them as pending / in progress for this PR

They are triggered only for push into master

@vmishenev vmishenev merged commit a9b3ee1 into master May 17, 2023
@vmishenev vmishenev deleted the update-kgp-1.8.20 branch May 17, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants