Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compiler plugin ] Support ColumnName annotation in extension properties codegen #818

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

koperagen
Copy link
Collaborator

Before this PR this code would fail with "abc is not found in dataframe" at runtime. After, behavior will be aligned with KSP

@DataSchema
data class Record(
    @ColumnName("a")
    val abc: String,
)

fun box(): String {
    val df = dataFrameOf("a")(1).cast<Record>()
    df.abc
    return "OK"
}

@koperagen koperagen self-assigned this Aug 7, 2024
@koperagen koperagen changed the title [Compiler plugin ]Support ColumnName annotation in extension properties codegen [Compiler plugin ] Support ColumnName annotation in extension properties codegen Aug 7, 2024
@Jolanrensen Jolanrensen added the Compiler plugin Anything related to the DataFrame Compiler Plugin label Aug 8, 2024
@koperagen koperagen merged commit 76c002c into master Aug 13, 2024
6 checks passed
@koperagen koperagen deleted the compiler-plugin-column-name branch August 26, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compiler plugin Anything related to the DataFrame Compiler Plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants