Add delimiter parameter to readDelimStr #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolanrensen
approved these changes
Jun 19, 2024
| @@ -46,7 +46,8 @@ class Write : TestBase() { | |||
| @Test | |||
| fun writeCsvStr() { | |||
| // SampleStart | |||
| val csvStr = df.toCsv(CSVFormat.DEFAULT.withDelimiter(';').withRecordSeparator(System.lineSeparator())) | |||
| val format = CSVFormat.DEFAULT.builder().setDelimiter(';').setRecordSeparator(System.lineSeparator()).build() | |||
There was a problem hiding this comment.
long line, but the linter will fix all these soon anyway
koperagen
force-pushed
the
read-csv-update
branch
from
6eb1efc
to
f7ba97c
Compare
koperagen
force-pushed
the
read-csv-update
branch
from
f7ba97c
to
3c9201b
Compare
|
Generated sources will be updated after merging this PR. |
|
Little comment, maybe since this is a function to especially read delimeters, it might be useful to have an override that takes in a Regex as a delimiter... this might be used for command line output tables that are usually space separated but sometimes inside a column value there might be a single space, so I need to use "\s\s+" to correctly read it in. |
|
@dave08 sounds like a good idea :) could you make an issue for that? |
|
Just opened one: #746 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.