Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a documentation for SQL database connection in Kotlin Notebooks #639

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

zaleslaw
Copy link
Collaborator

@zaleslaw zaleslaw commented Mar 25, 2024

USE {
dependencies("org.mariadb.jdbc:mariadb-java-client:$version")
}
```

In the second, enable the `Kotlin DataFrame` library usage in the following cell.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"In the second" looks weird, I'd rephrase the entire sentence to make it a bit more concise:

Next, import Kotlin DataFrame in the cell below

Copy link
Collaborator

@Jolanrensen Jolanrensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small thing :)

@zaleslaw zaleslaw merged commit 35792c9 into Kotlin:master Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect documentation and example for reading SQL database with dataframe in Notebook
2 participants