Allow any ArrowReader implementation to be use for reading Arrow data #627 #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb64
force-pushed
the
improve-arrow-reading
branch
2 times, most recently
from
2457bf8
to
67df4a3
Compare
Jolanrensen
reviewed
Mar 18, 2024
| import java.time.LocalDate | ||
| import java.time.LocalDateTime | ||
| import java.time.ZoneOffset | ||
| import java.util.Locale | ||
| import java.util.* |
There was a problem hiding this comment.
We turn off * imports in the project. So could you do that for consistency too?
Jolanrensen
reviewed
Mar 18, 2024
| @@ -558,23 +565,26 @@ internal class ArrowKtTest { | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| fun testArrowReaderExtension() { | |||
| private fun expectedSimpleDataFrame(): AnyFrame{ | |||
There was a problem hiding this comment.
missed a space before "{"
There was a problem hiding this comment.
Fixed, weird thing that was not detected by linter during my local build
There was a problem hiding this comment.
Yes, our linter is a bit broken :/ #364
fb64
force-pushed
the
improve-arrow-reading
branch
2 times, most recently
from
7df9251
to
b6ab5ea
Compare
fb64
force-pushed
the
improve-arrow-reading
branch
from
b6ab5ea
to
e85ec1d
Compare
fb64
force-pushed
the
improve-arrow-reading
branch
from
e85ec1d
to
56d27e6
Compare
|
CI agrees, I merged it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArrowFileReader part use specific method while ArrowStreamReader part rely only on ArrowReader interface methods. This modification just enables any ArrowReader implementation to be use for reading arrow data