-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for mac-os permissions pre-commit #616
Conversation
@devcrocod Could you check the latest version of this branch on your mac? |
I enabled the workaround for Linux too since we noticed the same problem happening there sometimes too. Plus, it doesn't hurt to run it if the problem isn't there. |
I can confirm that chmod does its job, but i don't like how that hook works now :c I tried to commit just one file, but it added all other uncommited files and delay was quite evident too |
I agree. It's mostly there so newly generated files are added to the git index automatically, because people forget. But it should mirror the commits to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for me. I don't particularly like this solution for aesthetic reasons, but it works.
Fixes #612