Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for mac-os permissions pre-commit #616

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Conversation

Jolanrensen
Copy link
Collaborator

Fixes #612

@Jolanrensen Jolanrensen added the bug Something isn't working label Mar 6, 2024
@Jolanrensen Jolanrensen added this to the 0.13.0 milestone Mar 6, 2024
@Jolanrensen Jolanrensen self-assigned this Mar 6, 2024
core/build.gradle.kts Outdated Show resolved Hide resolved
@Jolanrensen
Copy link
Collaborator Author

@devcrocod Could you check the latest version of this branch on your mac?

@Jolanrensen Jolanrensen requested review from devcrocod and removed request for zaleslaw March 7, 2024 11:26
@Jolanrensen
Copy link
Collaborator Author

I enabled the workaround for Linux too since we noticed the same problem happening there sometimes too. Plus, it doesn't hurt to run it if the problem isn't there.

@koperagen
Copy link
Collaborator

koperagen commented Mar 8, 2024

I can confirm that chmod does its job, but i don't like how that hook works now :c I tried to commit just one file, but it added all other uncommited files and delay was quite evident too

@Jolanrensen
Copy link
Collaborator Author

Jolanrensen commented Mar 8, 2024

I can confirm that chmod does its job, but i don't like how that hook works now :c I tried to commit just one file, but it added all other uncommited files and delay was quite evident too

I agree. It's mostly there so newly generated files are added to the git index automatically, because people forget. But it should mirror the commits to src only.
That said, that's another issue :)

Copy link
Contributor

@devcrocod devcrocod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. I don't particularly like this solution for aesthetic reasons, but it works.

@Jolanrensen Jolanrensen merged commit 21da606 into master Mar 12, 2024
1 of 2 checks passed
@Jolanrensen Jolanrensen deleted the mac-pre-commit-permission branch March 12, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect permission setting for the pre-commit file
3 participants