make sure to adjust nullability in order to fix platform types #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platform types can lead to unexpected NPE and the way types rendered now, "URI!" ! sign appears. Code with such type cannot be compiled Given type URI!, type.withNullability will produce either URI or URI?. Both are OK for us.
When will it produce either the nullable one or the non-nullable one? |
|
I just wanted to say that calling |
zaleslaw
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform types can lead to unexpected NPE and the way types rendered now: "URI!" - ! sign appears. Code with such type cannot be compiled Given type URI!, type.withNullability will produce either URI or URI?. Both are OK for us.