Fix performance problem in rename implementation
#532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you rebase on the master so that the TeamCity tests pass (includes #535) and |
…nstead of column content as a key for `associateBy`.
nikitinas
force-pushed
the
fix-rename-performance
branch
from
72ef35d
to
046cd0c
Compare
|
Done |
Jolanrensen
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
DataColumnobject is used as a key forassociateByinrenameimplementation. It leads to computation of rolling hash function and scanning through all column data. This problem can be seen in stack trace for #526Instead, a column path should be used as column id.