Add read of Arrow TimeStamp without timezone as LocalDatetime #515

[fb64]

Implementation of Arrow TimeStamp types (without time zone)

[Jolanrensen]

Thanks for the addition and the tests!
Please lint your (test) files, otherwise our CI will fail. You can test this by running gradlew lintKotlin.
In the future we should probably think about using Kotlinx LocalDateTime instead of the Java one, but since the Java variants are already used in the other Arrow functions, this is probably fine for now.

[Jolanrensen]

After #521 is merged, please rebase, fix the linting issues and then it can be merged :)

[Jolanrensen]

It's merged, please rebase so we can merge your branch too :)

[fb64]

It's merged, please rebase so we can merge your branch too :)

I think it's ok, you can check and merge

[Jolanrensen]

Almost :) sorry to nitpick.
The CI tests I ran successfully on https://github.com/Kotlin/dataframe/tree/fb64-master btw :)

[fb64]

Almost :) sorry to nitpick. The CI tests I ran successfully on https://github.com/Kotlin/dataframe/tree/fb64-master btw :)

no problem, it's weird I ran formatKotlin and full build was ok. I don't know this parser maybe it's a missing check 🤔
It should be the ok by now 🤞

[Jolanrensen]

Almost :) sorry to nitpick. The CI tests I ran successfully on https://github.com/Kotlin/dataframe/tree/fb64-master btw :)

no problem, it's weird I ran formatKotlin and full build was ok. I don't know this parser maybe it's a missing check 🤔 It should be the ok by now 🤞

Thanks! I suspect it's because we had to turn off a linter rule because it broke in some scenario. For this specific one I think it's because we allow notations like df[{ something }] which the linter tries to fix to df[ { something}]...
One day we'll switch to a better solution hopefully: #364

[fb64]

Well, you can close the related issue #515