use range indexing to get rows subset #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolanrensen
reviewed
Nov 23, 2023
| @@ -60,7 +59,7 @@ public object KotlinNotebookPluginUtils { | |||
| * It's used for example for dynamic pagination in Kotlin Notebook Plugin. | |||
| */ | |||
| public fun getRowsSubsetForRendering(df: AnyFrame, startIdx: Int, endIdx: Int): DisableRowsLimitWrapper = | |||
| DisableRowsLimitWrapper(df.filter { it.index() in startIdx until endIdx }) | |||
| DisableRowsLimitWrapper(df[startIdx until endIdx]) | |||
There was a problem hiding this comment.
cool place to try the new ..< operator :D
There was a problem hiding this comment.
new shiny! i'll use it indeed
Jolanrensen
approved these changes
Nov 23, 2023
koperagen
force-pushed
the
get-subset-fix
branch
from
44ef6fb
to
3ddf7c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that previous implementation took 200 ms to execute on 10m rows dataframe because it iterates over all rows. Indexing should improve it