Fixes related to Kotlin Notebook plugin integration #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…column names clashes Moved `convertToDataFrame` function KotlinNotebookPluginUtils and made it public to make it acessible in Kotlin Notebook plugin. An auxiliary method to generate unique variations of a string was added to fix issue with column names clashes when convert intermediate object to dataframe. Fixes KTNB-424, KTNB-415
Jolanrensen
approved these changes
Nov 13, 2023
core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/RenderingTests.kt
Show resolved
Hide resolved
core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/RenderingTests.kt
Outdated
Show resolved
Hide resolved
core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/RenderingTests.kt
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/KotlinNotebookPluginUtils.kt
Show resolved
Hide resolved
koperagen
requested changes
Nov 13, 2023
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/KotlinNotebookPluginUtils.kt
Outdated
Show resolved
Hide resolved
Introduced two public methods named `sortByColumns` in KotlinNotebookPluginUtils for sorting a dataframe-like object, or a specific dataframe by multiple columns. This added functionality will aid in sorting dataframes in Kotlin Notebook plugin. Implemented measures to handle null dataframes and conflicting column sizes. Fixes KTNB-426. Co-authored-by: Jolan Rensen <[email protected]>
Updated the 'generateRandomVariationOfString' function to 'generateRandomVariationOfColumnName' in 'KotlinNotebookPluginUtils.kt' to ensure uniqueness among used names. ColumnNameGenerator was used to create unique column names based on preferred name and used column names.
ermolenkodev
force-pushed
the
KTNB-424
branch
from
135a961
to
d15ecda
Compare
koperagen
approved these changes
Nov 13, 2023
|
@ermolenkodev Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.