Deprecation messages #430
Merged
Deprecation messages #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…updated the file with regions and hints to when a feature will be removed
zaleslaw
reviewed
Jul 25, 2023
| @@ -29,3 +29,8 @@ | |||
| 17. Create Release from the release tag on GitHub | |||
| 18. Update a KDF version in the [Kotlin Jupyter Descriptor](https://github.com/Kotlin/kotlin-jupyter-libraries/blob/master/dataframe.json). Now the Renovate bot doing this | |||
| 19. Update DataFrame version in gradle.properties file for next release cycle (i.e. 0.10.0 -> 0.11.0) | |||
| 20. Update deprecated functions in [deprecationMessages.kt](/core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/util/deprecationMessages.kt) | |||
| such that | |||
| - `Level.WARNING` messages are changed to `Level.ERROR` | |||
There was a problem hiding this comment.
Looks like a post-release section with 19 paragraph
zaleslaw
reviewed
Jul 25, 2023
...enerated-sources/src/main/kotlin/org/jetbrains/kotlinx/dataframe/util/deprecationMessages.kt
Outdated
Show resolved
Hide resolved
zaleslaw
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a tip from @zaleslaw in #372, we currently don't have any central indication as to when deprecated functions will be removed and whatnot. We did already have a
deprecationMessages.ktfile, containing some const messages.I updated the file with instructions and added versions to the remove-messages.
I also went through the rest of the core module as well to get the deprecations in the same central place. The columns selection DSL will also deprecate a lot of functions, so it's good to have this present ahead of that. (I won't include that in this PR as that's too large)