Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compilation for markers with empty bodies in Jupyter #427

Merged
merged 1 commit into from
Jul 21, 2023
Merged

fix compilation for markers with empty bodies in Jupyter #427

merged 1 commit into from
Jul 21, 2023

Conversation

koperagen
Copy link
Collaborator

No description provided.

@koperagen koperagen requested a review from zaleslaw July 21, 2023 10:33
zaleslaw
zaleslaw approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@zaleslaw zaleslaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR, it was tiny and helped me to understand some things during the process useful for another task!

core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/codeGen/CodeGeneratorImpl.kt Show resolved Hide resolved
@koperagen koperagen merged commit 5488a34 into master Jul 21, 2023
@zaleslaw zaleslaw added this to the 0.12.0 milestone Oct 9, 2023
@koperagen koperagen deleted the marker-compilation branch August 26, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaleslaw zaleslaw zaleslaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@koperagen @zaleslaw