Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add row functions to "operations overview" to make it comprehensive #412

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

koperagen
Copy link
Collaborator

It's nice to have a list of most functions on the same page, also an example on how to reuse content with writerside :)

@zaleslaw
Copy link
Collaborator

I approve, but suggest returning to the next release cycle to the discussion about page structure for column/row ops

@@ -37,6 +37,14 @@ Most multiplex operations end with `into` or `with` function. The following nami
* `into` defines column names for storing operation results. Used in [`move`](move.md), [`group`](group.md), [`split`](split.md), [`merge`](merge.md), [`gather`](gather.md), [`groupBy`](groupBy.md), [`rename`](rename.md).
* `with` defines row-wise data transformation with [`row expression`](DataRow.md#row-expressions). Used in [`update`](update.md), [`convert`](convert.md), [`replace`](replace.md), [`pivot`](pivot.md).

## List of DataRow operations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a title, probably write "Operations" with a capital. Same as for the other headers in the file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kotlin documentation and writerside documentation doesn't use title case, i think we probably shouldn't bother either? https://kotlinlang.org/docs/server-overview.html#deploying-kotlin-server-side-applications
https://kotlinlang.org/docs/constructing-collections.html

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! But then we do need to make sure to remove all title case usages in the rest of the file(s). I'll add it here

@@ -66,8 +70,12 @@ df.update { weight }.where { index() > 4 && city != "Paris" }.withValue(50)

Row condition signature: ```DataRow.(DataRow) -> Boolean```



## Row statistics
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Statistics

@Jolanrensen Jolanrensen added this to the 0.11.0 milestone Jun 22, 2023
@Jolanrensen Jolanrensen added the documentation Improvements or additions to documentation (not KDocs) label Jun 22, 2023
@koperagen koperagen merged commit 8c23189 into master Jun 22, 2023
@koperagen koperagen deleted the operations-list-update branch August 26, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation (not KDocs)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants