Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Jupyter compile-time DF type not recognized #401

Merged
merged 7 commits into from
Jun 21, 2023

Conversation

Jolanrensen
Copy link
Collaborator

Fixes #284.

Basically, an updateVariable case was added for the Any type, which then checks (in the correct "reversed" order) the instances of the types to update the variable (including a new cast-operation).

Tests appear to be working fine, as well as actual notebooks, but feel free to try it for yourself.

@Jolanrensen Jolanrensen added bug Something isn't working enhancement New feature or request labels Jun 12, 2023
@Jolanrensen Jolanrensen added this to the 0.11.0 milestone Jun 12, 2023
@Jolanrensen Jolanrensen self-assigned this Jun 12, 2023
Copy link
Collaborator

@zaleslaw zaleslaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks that better to have some String constants separately with giving some explanation about types and so on

@Jolanrensen
Copy link
Collaborator Author

Jolanrensen commented Jun 13, 2023

It looks that better to have some String constants separately with giving some explanation about types and so on

Agreed, I thought of using KotlinPoet or something to generate the name from the class name, but I couldn't yet figure out how to generate a <*> after ColumnGroup. Plus, we have to deal with type aliases... Will try again though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jupyter compile-time DF type not recognized
3 participants