Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the Gradle and Kotlin build snippets for Android and Server-side #400

Merged
merged 4 commits into from
Jun 14, 2023

Conversation

zaleslaw
Copy link
Collaborator

Fixed #374

@zaleslaw
Copy link
Collaborator Author

Hi, I've built projects with build.gradle for server side and Android; snippets should work correctly

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@Jolanrensen
Copy link
Collaborator

Jolanrensen commented Jun 12, 2023

I think the examples didn't change anything from https://github.com/Jolanrensen/DataframeTestApplication right? Otherwise, we should also update that.

@zaleslaw
Copy link
Collaborator Author

@Jolanrensen yes, I visited your example application to set up a config, no breaking changes, probably removed unused parts for my example

@Jolanrensen
Copy link
Collaborator

@zaleslaw not sure why TC is complaining, but it might be better for us to create branches inside this project, not your own fork, since it tries to authenticate for your fork currently

@zaleslaw zaleslaw merged commit 178a094 into Kotlin:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Gradle snippets for Server-side and Android developers in Readme.md
2 participants