[Fix] Update.asFrame now takes filter into account. #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… operation only on the filtered items
Jolanrensen
added
bug
zaleslaw
requested changes
Feb 28, 2023
core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/api/update.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/update.kt
Outdated
Show resolved
Hide resolved
core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/api/update.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/update.kt
Outdated
Show resolved
Hide resolved
|
@zaleslaw Greatly simplified the function :) didn't know I could make it this small. Should also make it easier to understand what's going on |
zaleslaw
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #280.
Similar to
Update.perCol {}, in the body ofasFrame, users will have access to the entire selected group column (treated as a DF), but now the result of the operation will only be applied to rows that satisfy a givenwhere/atclause of theupdatecall chain.See the new test for an example.