Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolute path fixes in plugins #191

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Absolute path fixes in plugins #191

merged 1 commit into from
Nov 30, 2022

Conversation

Jolanrensen
Copy link
Collaborator

defaultPath in AbstractDefaultReadMethod implementing IO methods will now be absolute path to solve difference between calls from gradle/the IDE. @ImportDataSchema and dataframes { schemas { data = "" } } now support absolute path too. Relative path will still be attempted first.

Fixes #139

… now be absolute path to solve difference between calls from gradle/the IDE. @ImportDataSchema and dataframes { schemas { data = "" } } now support absolute path too. Relative path will still be attempted first.
@Jolanrensen Jolanrensen self-assigned this Nov 28, 2022
@Jolanrensen Jolanrensen added the bug Something isn't working label Nov 28, 2022
@Jolanrensen Jolanrensen added this to the 0.9.0 milestone Nov 28, 2022
@Jolanrensen Jolanrensen added the enhancement New feature or request label Nov 28, 2022
@@ -64,18 +79,23 @@ fun main() {
}
}

fun <T> DataFrame<T>.toTrainTest(trainRatio: Double, yColumn: ColumnSelector<T, Number>): Pair<OnHeapDataset, OnHeapDataset> =
toOnHeapDataset(yColumn).split(trainRatio)
fun <T> DataFrame<T>.toTrainTest(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's agree to create separate commits for this kind of changes? it will be easier to review without taking time to make sure semantics haven't changed, because now it's a bit painful

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to, but even having a file opened, after I press run, then IntelliJ lints it XD Then it feels wrong to undo it again. It's good practice for code I write myself.
I'll go look for that setting next. I understand it's difficult to check it like this, so I'll try.
However, the entire project could do with a good linting, cause in almost every file there are long lines, mixed named and positional arguments, missing spaces before brackets etc. etc. Will get to that one day :)

@Jolanrensen Jolanrensen merged commit a87b440 into master Nov 30, 2022
@Jolanrensen Jolanrensen deleted the path-fixes branch November 30, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

readCSV using ImportDataSchema does not yield correct path
2 participants